Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large difference in results between TF and pytorch #326

Open
lyxxxyl opened this issue Jul 24, 2024 · 3 comments
Open

Large difference in results between TF and pytorch #326

lyxxxyl opened this issue Jul 24, 2024 · 3 comments

Comments

@lyxxxyl
Copy link

lyxxxyl commented Jul 24, 2024

I have found when doing feature extraction on the same images that the tf version will all have a greater number of feature points than the pytorch version, the weights I use are sp_v6 and superpoint_v6_from_tf.pth respectively and when the input is a blank image, the tf result will be the points on the four corners of the image and the pytorch result will be empty.

@lyxxxyl
Copy link
Author

lyxxxyl commented Jul 24, 2024

When I do feature extraction on two images using the tf version, the shapes of keypoints, descriptors, scores are as follows
image

And the result of torch version is as follows
image

@lyxxxyl
Copy link
Author

lyxxxyl commented Jul 24, 2024

For images with many feature points, the difference is even greater
image

@rpautrat
Copy link
Owner

Hi, this is probably due to different confidence threshold to decide how many keypoints you are keeping. Please check that you are using the same thresholds.

Note that there was already a similar issue on the topic: #316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants