-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust 1.62 doesn't like the docstring on instrinsics #374
Comments
Looks like before 1.62, non-expored macros were not doc-tested: |
jannic
added a commit
that referenced
this issue
Jul 7, 2022
While the code block fails to compile, it's still code and not random text. Marking it with `ignore` allows for proper syntax highlighting, for example. According to rust-lang/rust#97030 (comment) this is the proper fix, so this closes #374
9names
pushed a commit
that referenced
this issue
Jul 8, 2022
While the code block fails to compile, it's still code and not random text. Marking it with `ignore` allows for proper syntax highlighting, for example. According to rust-lang/rust#97030 (comment) this is the proper fix, so this closes #374
ExplodingWaffle
pushed a commit
to ExplodingWaffle/rp-hal
that referenced
this issue
Aug 14, 2022
While the code block fails to compile, it's still code and not random text. Marking it with `ignore` allows for proper syntax highlighting, for example. According to rust-lang/rust#97030 (comment) this is the proper fix, so this closes rp-rs#374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the new Rust release (1.62.0), cargo doc has a failing test for the code in this docstring, which CI is upset about.
I plan to merge a small PR that comments out the code to get it to work again. This issue is to remind us to investigate and either report or fix (depending on whether this breakage is our fault or cargo doc's)
The code that breaks is here
rp-hal/rp2040-hal/src/intrinsics.rs
Line 61 in b12aecb
I've quoted it below to make it a bit more accessible.
The text was updated successfully, but these errors were encountered: