Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

purescript & spago should be an optional dependency in package.json #2

Open
toastal opened this issue Aug 7, 2021 · 3 comments
Open

Comments

@toastal
Copy link

toastal commented Aug 7, 2021

Or possibly dropped altogether with the implication that the user should have installed it already? By default, just installing PureScript through generic NPM is incompatible with Nix (because of dynamic linking, hence why easy-purescript-nix exists). Users may also be getting their PureScript binary from other avenues like asdf or Docker or the OS.

I am trying to add this upstream to nixpkgs. I'm starting to ./generate.sh it, but I have a feeling it may fail because of this requirement (and even if it does work, it's kinda wasteful to download and not use the binary specifically).

@i-am-the-slime
Copy link
Member

I'd be happy to merge a PR that moves purescript (and spago?) to optionalDependencies if it helps nix users.

@i-am-the-slime
Copy link
Member

@toastal Also currently I haven't worked much with the non-prettier integration/standalone formatter, it's quite possible that we can improve the feature set here by providing more flags and ways of reading and writing output.

@toastal toastal changed the title purescript should be an optional dependency in package.json purescript & spago should be an optional dependency in package.json Aug 7, 2021
@toastal
Copy link
Author

toastal commented Aug 7, 2021

The documentation could say that you should install PureScript and Spago or use npx to download them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants