Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISL mixed with RFServer #8

Open
ghost opened this issue Nov 8, 2013 · 1 comment
Open

ISL mixed with RFServer #8

ghost opened this issue Nov 8, 2013 · 1 comment

Comments

@ghost
Copy link

ghost commented Nov 8, 2013

The ISL implementation in RFServer should be properly separated in its own class class that inherits from RFServer. This class would be in a module of its own, becoming an option to the user.

Joe, how hard do you think this would be? I took a quick look at the code, and it seems easy. I can separate it if you want, but I don't have the knowledge to test it...

@joestringer
Copy link

I was encouraging @KitL to try to revamp RFServer along this idea, but it turns out that it's not that straightforward. I don't really recall the details, but it seems error-prone particularly if you don't spend the time to sit down and understand how ISL works. As I understand the current ISL code has also changed significantly since this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant