Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin 'password' > Setting password_minimum_score = 4 returns "password is too weak" for secure passwords #9751

Open
2 tasks done
cmonty14 opened this issue Jan 11, 2025 · 1 comment

Comments

@cmonty14
Copy link

cmonty14 commented Jan 11, 2025

Prerequisites

  • I have searched for duplicate or closed issues
  • I can recreate the issue with all plugins disabled

Describe the issue

Hello,
I enabled pluging password with these settings:

$config['password_strength_driver'] = 'pwned';
$config['password_minimum_length'] = 8;
$config['password_minimum_score'] = 4;

Changing current password to Z8@aXZ)cm^SQtNR6MbFj returns: password too weak.
(I have no problem to paste the password here in cleartext, because it's a randomly generated example.)

Imo this password is secure, and it's reported green by Have I Been Pwned.

Why is password_minimum_score = 4 causing this failure?

What browser(s) are you seeing the problem on?

Chrome, Edge

What version of PHP are you using?

v8.2

What version of Roundcube are you using?

v1.6.5

JavaScript errors

No response

PHP errors

No response

@johndoh
Copy link
Contributor

johndoh commented Jan 11, 2025

From the comments at the top of the pwned driver file.

This driver will return a strength of:
    3: if the password WAS NOT found in HIBP
    1: if the password WAS found in HIBP
    2: if there was an ERROR retrieving data. 
....
Setting the minimum score to 1 or less effectively renders
the checks useless, as all passwords would be accepted.
Setting it to 4 or more will effectively reject all passwords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants