Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup does not remove .nojekyll file #15

Open
EndBug opened this issue Aug 31, 2022 · 2 comments · May be fixed by #17
Open

Cleanup does not remove .nojekyll file #15

EndBug opened this issue Aug 31, 2022 · 2 comments · May be fixed by #17
Labels
bug Something isn't working

Comments

@EndBug
Copy link
Contributor

EndBug commented Aug 31, 2022

Hi, thanks for the awesome action!
I was just testing it on a repo and I found out that when the PR is closed the preview is correctly removed, but a .nojekyll file hangs around in the directory. Do you know why?

Here are some links:

Thanks for the help ❤️
@rossjrw
Copy link
Owner

rossjrw commented Sep 1, 2022

Funnily enough, I can think of a reason why. This is behaviour specific to JamesIves/github-pages-deploy-action, which this action uses under the hood. JamesIves' action is intended for traditional single-site deployments, and intentionally does not remove CNAME and .nojekyll files during its clean process.

You can see the reasoning here: JamesIves/github-pages-deploy-action#354

However, for a removed preview, these files are definitely not useful, so this action should take care of removing them as well. Therefore I'm going to consider this a bug.

It'll be a while before I can get around to working on this again, so in the meantime you might have some luck with detecting the preview path yourself and adding an extra step to your removal workflow to delete those files. Or, if you feel comfortable with it, I'd gladly accept a PR.

@rossjrw rossjrw added the bug Something isn't working label Sep 1, 2022
@EndBug
Copy link
Contributor Author

EndBug commented Sep 2, 2022

Related: JamesIves/github-pages-deploy-action#1210

EndBug added a commit to EndBug/pr-preview-action that referenced this issue Sep 2, 2022
@EndBug
fix: remove all files in target directory
8637221 
Closes rossjrw#15
Related future improvements:
JamesIves/github-pages-deploy-action#1210
EndBug/add-and-commit#429
@EndBug EndBug linked a pull request Sep 2, 2022 that will close this issue
Open
@kdheepak kdheepak mentioned this issue Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove every file when cleaning up PR preview EndBug/pr-preview-action
2 participants
@EndBug @rossjrw