Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: searchParam not implemented #41

Open
xdaco opened this issue Oct 31, 2019 · 3 comments
Open

Error: searchParam not implemented #41

xdaco opened this issue Oct 31, 2019 · 3 comments
Assignees

Comments

@xdaco
Copy link

xdaco commented Oct 31, 2019

I was trying vapor-master with one of our robot packages (originally developed on ros kinetic ) and got the following error. Our package is well tested and it works fine with ros kinetic ros_master.
Any help/workaround will be appreciated !!

Error: searchParam not implemented at Master.exports.searchParam (/snap/vapor-master/65/node_modules/vapor-master/src/param-api.js:119:9) at _callee$ (/snap/vapor-master/65/node_modules/vapor-master/node_modules/@roshub/express-xmlrpc/dist/index.js:147:32) at tryCatch (/snap/vapor-master/65/node_modules/vapor-master/node_modules/regenerator-runtime/runtime.js:45:40) at Generator.invoke [as _invoke] (/snap/vapor-master/65/node_modules/vapor-master/node_modules/regenerator-runtime/runtime.js:271:22) at Generator.prototype.(anonymous function) [as next] (/snap/vapor-master/65/node_modules/vapor-master/node_modules/regenerator-runtime/runtime.js:97:21) at asyncGeneratorStep (/snap/vapor-master/65/node_modules/vapor-master/node_modules/@babel/runtime-corejs2/helpers/asyncToGenerator.js:5:24) at _next (/snap/vapor-master/65/node_modules/vapor-master/node_modules/@babel/runtime-corejs2/helpers/asyncToGenerator.js:27:9) at /snap/vapor-master/65/node_modules/vapor-master/node_modules/@babel/runtime-corejs2/helpers/asyncToGenerator.js:34:7 at new Promise (<anonymous>) at new F (/snap/vapor-master/65/node_modules/vapor-master/node_modules/core-js/library/modules/_export.js:36:28) at /snap/vapor-master/65/node_modules/vapor-master/node_modules/@babel/runtime-corejs2/helpers/asyncToGenerator.js:23:12 at /snap/vapor-master/65/node_modules/vapor-master/node_modules/@roshub/express-xmlrpc/dist/index.js:187:21 at Layer.handle [as handle_request] (/snap/vapor-master/65/node_modules/vapor-master/node_modules/express/lib/router/layer.js:95:5) at next (/snap/vapor-master/65/node_modules/vapor-master/node_modules/express/lib/router/route.js:137:13) at Route.dispatch (/snap/vapor-master/65/node_modules/vapor-master/node_modules/express/lib/router/route.js:112:3) at Layer.handle [as handle_request] (/snap/vapor-master/65/node_modules/vapor-master/node_modules/express/lib/router/layer.js:95:5)

@sevenbitbyte
Copy link
Member

@NickZ What is the level-of-effort to finish the param-api.searchParam?

// searchParam(caller_id, key)
// -> (code, statusMessage, foundKey)
exports.searchParam = async function(req, res) {
const [callerPath] = req.body.params
//coreUtil.logTouch(this.db, callerPath, null, req.ip)
throw new Error('searchParam not implemented')
}

@NickZ
Copy link

NickZ commented Nov 4, 2019

This shouldn't be a huge amount of effort, this would be a simple mongodb query in the params table and then sorting by path to find the first partial match in the namespace.

RosMaster SearchParam api listing
Mongoose

@sevenbitbyte
Copy link
Member

@NickZ how'd we miss this in matching ROS Test results for rosmaster?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants