Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

dificult to read #10

Open
AlbanMinassian opened this issue Oct 25, 2018 · 8 comments
Open

dificult to read #10

AlbanMinassian opened this issue Oct 25, 2018 · 8 comments

Comments

@AlbanMinassian
Copy link

hello

Is not an issue

It took me a long time to read the results (which is the fastest, slowest, ...) and I wanted to let you know that there is a graph that is faster to read (or understand): for example, you can see the website https://github.com/ebdrup/json-schema-benchmark or https://www.techempower.com/benchmarks/#section=data-r16&hw=ph&test=fortune who display faster at 100% and others relatif to faster.

Thank you for this work.
ami44

@djc
Copy link
Collaborator

djc commented Oct 29, 2018

Thanks for the issue. For now I consider reading it easy enough; and the current plot adds information that I perceive as important to understand the relative performance. If more people find this problematic, or if someone is more motivated to improve on this, I'd be happy to review a patch!

@AlbanMinassian
Copy link
Author

Thank for your answer.
Ok, maybe a day ...

@djc djc reopened this Nov 1, 2018
@djc
Copy link
Collaborator

djc commented Nov 1, 2018

Let's leave this open so others can find it more easily.

@naturallymitchell
Copy link

maybe a bar graph?

first time seeing a violin graph, for me

very helpful info. thx @djc

@RamonZoocha
Copy link

RamonZoocha commented Aug 13, 2020

Thanks, me be dumb, I don't get the graph.

@ssokolow
Copy link

ssokolow commented Jan 7, 2021

At the very least, perhaps sort them by the average time taken?

As-is, Handlebars, Horrorshow, and Tera balloon out the scale so much that the violin plots are difficult to use to compare the fastest entries and I find myself only being able to get use out of the information if I copy-paste the "Numbers, as output by Criterion:" section into a text editor and manually sort the rows.

Heck, I opened the SVGs in their own browser tabs and, even when I zoomed it up, I still couldn't see the violin for Sailfish on the Big Table benchmark.

@djc
Copy link
Collaborator

djc commented Jan 7, 2021

I'm unlikely to spend much time on this. However, if someone can devise a low-maintenance alternative way to present the data, I'm happy to review it.

@jemma-nelson
Copy link

Related - the SVG generated has a transparent background, which makes it very difficult to read when rendered against github Dark Mode - I initially didn't realize it was there at all. Please consider rendering with a white or other light-color background. Screenshot attached.
Workaround: Right-click, open image in new tab.
Screen Shot 2022-04-11 at 12 45 17 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants