Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphs are unreadable using dark mode #2

Open
kirawi opened this issue Mar 27, 2022 · 1 comment
Open

Graphs are unreadable using dark mode #2

kirawi opened this issue Mar 27, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@kirawi
Copy link

kirawi commented Mar 27, 2022

Perhaps a white background would help?

@epage
Copy link
Collaborator

epage commented Mar 28, 2022

When you click through to the details, do you get the needed white background

If you look at the template benchmarks, does it have the same problem?

The core issue is a combination of

  • criterion is generating the images for us and isn't providing a background
  • we are embedding the image into a github readme which allows people to control the background color
  • I don't want a heavy process (e.g. a redditor does custom anslysis in R but I don't want to pull in an extra toolchain and require knowing a specialized language)

If people have an idea on how to address one of these so it can be improved, I'm game.

@epage epage added the bug Something isn't working label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants