Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not score checked in libraries #56

Open
mihaibivol opened this issue Jan 27, 2015 · 4 comments
Open

Do not score checked in libraries #56

mihaibivol opened this issue Jan 27, 2015 · 4 comments

Comments

@mihaibivol
Copy link
Member

Add a method for not scoring commits adding 3rd party code such as *.min.js and *.min.css

As I am not familiar with the codebase I can't actually propose an accurate solution.

@maria
Copy link
Member

maria commented Jan 27, 2015

You can't actually know. But the mentor can add a smaller rating to the PR, and lines added have less value than removed lines. So the score will be low.

@mihaibivol
Copy link
Member Author

Is this documented somewhere?

@maria
Copy link
Member

maria commented Jan 28, 2015

No. We talked and we might have found a solution. Will let you know.

@mihaibivol
Copy link
Member Author

Fun fact: http://githut.info/
Probably the same cause of js being ahead of everything else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants