Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionSpecification in rosidl_adapter.parser missing attributes. #829

Open
InvincibleRMC opened this issue Oct 4, 2024 · 0 comments
Open

Comments

@InvincibleRMC
Copy link
Contributor

Bug report

While doing #828 I noticed the following.

Required Info:

In this definition there is no goal_service or result_service.

class ActionSpecification:
def __init__(self, pkg_name, action_name, goal, result, feedback):
self.pkg_name = pkg_name
self.action_name = action_name
assert isinstance(goal, MessageSpecification)
self.goal = goal
assert isinstance(result, MessageSpecification)
self.result = result
assert isinstance(feedback, MessageSpecification)
self.feedback = feedback

But they are used here

elif isinstance(spec, ActionSpecification):
spec_type = 'Action'
fields = []
for service in [spec.goal_service, spec.result_service]:
fields += service.request.fields
fields += service.response.fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant