Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Writing to ostreams #1681

Open
methylDragon opened this issue May 31, 2024 · 0 comments
Open

Support Writing to ostreams #1681

methylDragon opened this issue May 31, 2024 · 0 comments
Labels
enhancement New feature or request mcap Concerning the MCAP storage plugin

Comments

@methylDragon
Copy link
Contributor

methylDragon commented May 31, 2024

Description

mcap::McapWriter supports writing to std::ostreams, so it would be good to extend that support to the writing of ROS Bags.

One can imagine streaming bag data to the cloud (e.g. opening an ostream that streams to an online location) in contexts with low disk space instead of writing to a file on disk.

The storage options don't suggest that this is possible, and the MCAP storage plugin doesn't look like it supports it either.

By right all that is needed is to have a conditional here in the storage plugin and pipe in the ostream accordingly.

However, I'm opening this as a feature request because I'm not sure how involved it would be to update the writer/storage interfaces and Python library to support this, or if there are other issues I am unaware of.

Completion Criteria

  • Refactor rosbag2_storage to support writing to ostreams
  • Refactor rosbag2_storage_mcap to support writing to ostreams
  • Refactor rosbag2_py to support writing to ostreams
  • Refactor rosbag2_cpp to support Writing to ostreams

Testing Notes / Suggestions

Previous unit tests should pass.

@methylDragon methylDragon added enhancement New feature or request mcap Concerning the MCAP storage plugin labels May 31, 2024
@methylDragon methylDragon changed the title Support Writing to ostreams Support Reading and Writing to and from i/ostreams May 31, 2024
@methylDragon methylDragon changed the title Support Reading and Writing to and from i/ostreams Support Writing to ostreams May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mcap Concerning the MCAP storage plugin
Projects
None yet
Development

No branches or pull requests

1 participant