typo: Fibonacci feedback_fieldname: sequence -> partial_sequence

[VladimirFokow]

Here (in section "Actions"):

For instance, the Fibonacci action definition contains the following:

int32 order
---
int32[] sequence
---
int32[] sequence

I think the feedback_fieldname sequence is a typo, and should be partial_sequence.

Because it's what it's called here and here

Within the action directory, create a file called Fibonacci.action with the following contents:

int32 order
---
int32[] sequence
---
int32[] partial_sequence

[clalancette]

Ah. So there is indeed some confusion here.

The most canonical thing to look at is the sources. There are a few different places where we define and use this:

• https://github.com/ros2/demos/blob/6ac07b927a99e7e5372eb1574b31e0f95c4f78d5/action_tutorials/action_tutorials_interfaces/action/Fibonacci.action indeed calls it "partial_sequence". This is the action most visible to users.
• https://github.com/ros2/test_interface_files/blob/c5941d36e977b75c8949c9d30883248246a84693/action/Fibonacci.action calls it "sequence". I think this file is really only used for tests, but I'm not sure.
• https://github.com/ros2/example_interfaces/blob/4d7d086e4791e1839fecb9c50a1291d4056b916f/action/Fibonacci.action also calls it "sequence". This one is used in some of our other example code.

Really what we should do is to fix the confusion in the sources first, and just have a single "Fibonacci.action" file. Once that is done, we can then update the documentation to reflect what we chose.

[ahcorde]

Hi @clalancette

waht do you think about keeping the example_interface/action/fibonacci and remove the other two inside test_interfaces_files and action_tutorials_interfaces ?

This may require changes in the following packages:

• rcl_interfaces
• example_interfaces (use partial_sequence)
• test_interface_files (remove Fibonacci.action)
• rosidl_generator_tests
• rcl_action
• Remove action_tutorials_interfaces
• action_tutorials/action_tutorials_py and action_tutorials/action_tutorials_cpp
• rclcpp_action
• system_tests