From ed3040ef0fd45472f0d5fec84052298334bcf0ca Mon Sep 17 00:00:00 2001 From: Felix Divo <4403130+felixdivo@users.noreply.github.com> Date: Tue, 4 May 2021 18:01:26 +0200 Subject: [PATCH 1/2] Better document parameter handling in Node Signed-off-by: Felix Divo --- launch_ros/launch_ros/actions/node.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/launch_ros/launch_ros/actions/node.py b/launch_ros/launch_ros/actions/node.py index 166a9774..a9ad42e6 100644 --- a/launch_ros/launch_ros/actions/node.py +++ b/launch_ros/launch_ros/actions/node.py @@ -171,9 +171,15 @@ def __init__( A yaml file with the resulting parameters from the dictionary will be written to a temporary file, the path to which will be passed to the node. - Multiple dictionaries/files can be passed: each file path will be - passed in in order to the node (where the last definition of a - parameter takes effect). + + Multiple parameter dictionaries/files can be passed: each file path + will be passed in in order to the node (where the last definition of + a parameter takes effect). + However, fully qualified node names override wildcards even when + specified earlier. + If `namespace` is not specified, dictionaries are prefixed by a + wildcard namespace (`/**`) and other specific parameter declarations + may overwrite it. :param: executable the name of the executable to find if a package is provided or otherwise a path to the executable to run. From 17e89c545850b990c3aab46ee267299a363755c1 Mon Sep 17 00:00:00 2001 From: Felix Divo Date: Wed, 5 May 2021 12:49:33 +0200 Subject: [PATCH 2/2] join paragraphs Signed-off-by: Felix Divo --- launch_ros/launch_ros/actions/node.py | 1 - 1 file changed, 1 deletion(-) diff --git a/launch_ros/launch_ros/actions/node.py b/launch_ros/launch_ros/actions/node.py index a9ad42e6..c5c1b85e 100644 --- a/launch_ros/launch_ros/actions/node.py +++ b/launch_ros/launch_ros/actions/node.py @@ -171,7 +171,6 @@ def __init__( A yaml file with the resulting parameters from the dictionary will be written to a temporary file, the path to which will be passed to the node. - Multiple parameter dictionaries/files can be passed: each file path will be passed in in order to the node (where the last definition of a parameter takes effect).