Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit drop ordering for rcl handles #377

Closed
mxgrey opened this issue Mar 20, 2024 · 2 comments
Closed

Audit drop ordering for rcl handles #377

mxgrey opened this issue Mar 20, 2024 · 2 comments
Assignees

Comments

@mxgrey
Copy link
Collaborator

mxgrey commented Mar 20, 2024

We've noticed that there may be issues with drop orders of rcl handles that are held by rclrs structs, e.g. #372 .

I'm not certain that #372 fixed all the problems that may exist, so I'll keep auditing the structs and drop order strategy to make sure it's sound.

Maintainers can feel free to assign this ticket to me.

@esteve
Copy link
Collaborator

esteve commented Mar 20, 2024

@mxgrey thanks for looking into it

@mxgrey
Copy link
Collaborator Author

mxgrey commented Apr 7, 2024

Closed by #386

@mxgrey mxgrey closed this as completed Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants