Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the dockerfile build the colcon workspace? #63

Open
ct2034 opened this issue Oct 12, 2024 · 1 comment
Open

Should the dockerfile build the colcon workspace? #63

ct2034 opened this issue Oct 12, 2024 · 1 comment

Comments

@ct2034
Copy link
Contributor

ct2034 commented Oct 12, 2024

A general thought: Why do we not build the workspace in the build? I mean in the dockerfile.
I do understand that during development that maybe didn't make a lot of sense because it was all WIP. But for the participants, I think it makes sense for the container to have the workspace build when you start it.
@sea-bass @dcconner What do you think?

@sea-bass
Copy link
Contributor

We can switch to this once we have a more stable setup. However, it may be tricky because participants will want to rebuild the workspace, and it may become difficult to reuse the build that happened at image build time, to speed up local rebuilds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants