From adaa0ff9ca27e72007d615d48195cc52177b1988 Mon Sep 17 00:00:00 2001
From: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>
Date: Fri, 18 Oct 2024 12:06:31 -0400
Subject: [PATCH] Fix typo in README.md and fix CI from forks (#76)

* Fix typo and add URL to README.md

This one is actually from my fork...

* Update lint.yml

* Do not push to ghcr from forks

* Gate release step as well
---
 .github/workflows/docker.yml | 6 +++++-
 .github/workflows/lint.yml   | 1 -
 README.md                    | 2 +-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
index 0568aca..a421234 100644
--- a/.github/workflows/docker.yml
+++ b/.github/workflows/docker.yml
@@ -50,7 +50,9 @@ jobs:
             src/technologies/convince/task_2_solution/
           docker compose run test bash -c "source /delib_ws/install/setup.bash && pytest /delib_ws/src/dependencies/convince/AS2FM/test"
           docker compose down --remove-orphans
-      - name: Push to gh registry with sha and branch name
+      - name: Push to gh registry with sha and branch
+        # Do not push on PRs from forks.
+        if: ${{ !github.event.pull_request.head.repo.fork }}
         run: |
           echo ${{ secrets.GITHUB_TOKEN }} | docker login ghcr.io -u ${{ github.repository_owner }} --password-stdin
           # tag with sha and push
@@ -72,6 +74,8 @@ jobs:
         run: |
           docker save ${{ env.REGISTRY_IMAGE }}:${{ env.TAG_NAME }} | gzip > ./roscon_delib_ws_2024.tar.gz
       - name: Release
+        # Do not release on PRs from forks.
+        if: ${{ !github.event.pull_request.head.repo.fork }}
         uses: ncipollo/release-action@v1
         with:
           artifacts: './roscon_delib_ws_2024.tar.gz'
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 2b6c7c4..8f80cf5 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -3,7 +3,6 @@ on:
   push:
     branches: [main]
   pull_request:
-    branches: [main]
 
 jobs:
   pre-commit:
diff --git a/README.md b/README.md
index a022b69..fd7916d 100644
--- a/README.md
+++ b/README.md
@@ -118,7 +118,7 @@ It will ask you for your `sudo` password.
 ### Develop inside the container using VSCode
 
 If you want to develop inside the container using VSCode, you need to have the [Docker extension](https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker) installed.
-To see option "Attach Visual Studio Code" you also need to download VS Code extenstion Dev Containers.
+To see the option "Attach Visual Studio Code", you also need to download the [Dev Containers extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers).
 
 Attach to the container as shown in the image below: