Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_sip_binding fails with Ninja build #111

Open
eaglesemanation opened this issue Dec 3, 2021 · 1 comment
Open

build_sip_binding fails with Ninja build #111

eaglesemanation opened this issue Dec 3, 2021 · 1 comment

Comments

@eaglesemanation
Copy link

On Fedora 35 build of qt_gui_cpp fails with this error:

CMake Error:
  Running

   '/usr/bin/ninja-build' '-C' '/home/eaglesemanation/Documents/Packages/ros2_galactic/build/qt_gui_cpp' '-t' 'recompact'

  failed with:

   ninja: error: build.ninja:673: bad $-escape (literal $ must be written as $$)

That is caused by hard-coded Make variable $(MAKE) in sip_helper.cmake. If I change it to make everything works correctly, but I'm not sure if it's a good solution.
On my system, CMake defaults to Ninja generator because I have defined environment variable CMAKE_GENERATOR=Ninja. If it's not supported, it should probably be mentioned in docs.

@peci1
Copy link

peci1 commented May 10, 2024

This started happening to me with rviz on Noetic. No big issue, I don't really need to use Ninja, but just wanted to let others know this is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants