Add a basic README and stop publishing to Docker Hub #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersonknapp
requested review from
MichaelOrlov,
jhdcs,
christophebedard and
wep21
and removed request for
a team
emersonknapp
force-pushed
the
emersonknapp/update-readme
branch
from
881d3a5
to
7e1e86e
Compare
MichaelOrlov
approved these changes
Jan 6, 2024
christophebedard
approved these changes
Jan 9, 2024
emersonknapp
force-pushed
the
emersonknapp/update-readme
branch
from
7e1e86e
to
e424352
Compare
| uses: docker/build-push-action@v5 | ||
| with: | ||
| context: . | ||
| platforms: linux/amd64,linux/arm64 | ||
| push: ${{ github.event_name != 'pull_request' }} | ||
| build-args: | | ||
| BASE_IMAGE_NAME=${{ matrix.base_image_name }} | ||
| BASE_IMAGE_TAG=${{ matrix.base_image_tag }} | ||
| BASE_IMAGE=${{ matrix.base_image_name }}:${{ matrix.base_image_tag }} |
There was a problem hiding this comment.
We have BASE_IMAGE_NAME and BASE_IMAGE_TAG instead of BASE_IMAGE now:
Lines 12 to 18 in 4397556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Never had a readme here, almost nobody even knew this existed or what it's for
Closes #64
Maybe I should separate these changes? But I found that the readme should explain what's actually happening and I didn't want to document something we were to immediately remove.