Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate compatibility of build scripts with Windows #44

Open
gavanderhoorn opened this issue Apr 11, 2019 · 4 comments
Open

Investigate compatibility of build scripts with Windows #44

gavanderhoorn opened this issue Apr 11, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@gavanderhoorn
Copy link
Member

Promoting #17 (comment) by @traversaro to this issue:

Besides #3, a few additional fixes will be necessary to correctly compiled the library on Windows. One issue for sure is symbol visibility, but that can be easily addressed by setting CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS to TRUE (see https://blog.kitware.com/create-dlls-on-windows-without-declspec-using-new-cmake-export-all-feature/).

If the library is supposed to be distributed in binary form on Windows, some additonal work may be necessary to create a relocatable CMake package (see https://cmake.org/cmake/help/v3.12/manual/cmake-packages.7.html#creating-relocatable-packages), to make sure that the library can be used also if it installed in a location different from the build-time installation destination.
@gavanderhoorn gavanderhoorn added the enhancement New feature or request label Apr 11, 2019
@gavanderhoorn gavanderhoorn mentioned this issue Apr 11, 2019
Closed
@traversaro
Copy link
Contributor

Related documentation from the ROSOnWindows project: https://ms-iot.github.io/ROSOnWindows/Porting/Cookbook .

@gavanderhoorn
Copy link
Member Author

abb_libegm is not a ROS package necessarily, but it's a nice checklist.

@gavanderhoorn
Copy link
Member Author

Related: #91.

@gavanderhoorn gavanderhoorn mentioned this issue May 10, 2020
Closed
@gavanderhoorn
Copy link
Member Author

Not really a build script per se, but Windows CI broke again: #156.

This needs more effort than just updating a single line, so just tracking it here for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@traversaro @gavanderhoorn