Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh Loading Failure #118

Open
marrts opened this issue May 24, 2024 · 4 comments
Open

Mesh Loading Failure #118

marrts opened this issue May 24, 2024 · 4 comments

Comments

@marrts
Copy link
Member

marrts commented May 24, 2024

If you pass a mesh to the motion planner and there is no mesh at that filepath it will print an error, but just continue with the motion plan. This could lead to unexpected behavior and motion plans that are not collision free.

[snp_motion_planning_node-8] Error:   Could not load mesh from "/tmp/results_mesh_asdfsa2.ply": Unable to open file "/tmp/results_mesh_asdfsa2.ply".
@marrts
Copy link
Member Author

marrts commented May 24, 2024

I think it would probably make the most sense to separate out the adding the mesh process from the motion plan call. This would give us more flexibility in motion planning to either require a mesh or not. It would also potentially enable adding multiple meshes if the scenario ever came up.

@marip8
Copy link
Member

marip8 commented May 24, 2024

Sounds like a reasonable approach to me

@Moonwanlite
Copy link

I think it would probably make the most sense to separate out the adding the mesh process from the motion plan call. This would give us more flexibility in motion planning to either require a mesh or not. It would also potentially enable adding multiple meshes if the scenario ever came up.

How would you separate out adding the mesh process?

@marrts
Copy link
Member Author

marrts commented Jun 25, 2024

How would you separate out adding the mesh process?

  1. Add a new service definition in the snp_msgs package.
  2. Add a new service to the planning server that has the sole purpose of adding a mesh to the environment.
  3. Add a new behavior tree node to call this service
  4. Modify the behavior tree pipelines to call this service where appropriate
  5. Remove references to adding a mesh in:
    • The motion planning service callback
    • Motion planning service msg definition
    • behavior tree node related to motion planning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants