Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repackage libfreenect example commands #4

Open
jack-oquin opened this issue May 7, 2013 · 6 comments
Open

repackage libfreenect example commands #4

jack-oquin opened this issue May 7, 2013 · 6 comments
Assignees

Comments

@jack-oquin
Copy link
Member

The example commands depend on heavyweight 3D GUI libraries, too big for a library that drivers use.

Also, these commands are installed in the global ros bin/ directory. Their names are not unique enough for that to be appropriate.

Either leave them out entirely, or move them to a separate package and install the commands in that package's lib/PACKAGENAME/ directory.

@ghost ghost assigned jack-oquin May 7, 2013
@piyushk
Copy link
Member

piyushk commented May 7, 2013

That seems fair to me. The easiest thing to do would be to patch the
CMakeLists to stop generating the binaries.

Is this the reason I am seeing spam about libfreenect source deb?

Thanks!
Piyush

On Tue, May 7, 2013 at 9:56 AM, jack-oquin [email protected] wrote:

The example commands depend on heavyweight 3D GUI libraries, too big for a
library that drivers use.

Also, these commands are installed in the global ros bin/ directory. Their
names are not unique enough for that to be appropriate.

Either leave them out entirely, or move them to a separate package and
install the commands in that package's lib/PACKAGENAME/ directory.


Reply to this email directly or view it on GitHubhttps://github.com//issues/4
.

@jack-oquin
Copy link
Member Author

I agree. We don't actually require them for freenect_camera.

Sometimes it would be useful to have some of those programs, perhaps for testing or diagnosing problems. That's why I would consider packaging them separately.

The libfreenect sourcedeb problem looks like something different to me. Maybe just a build farm screw-up, or maybe something I did wrong during the release cycle. It's complaining about checksum mismatches.

I asked about it on the ros-release ML: https://code.ros.org/lurker/message/20130507.153722.2359b1de.en.html

I forgot to copy you on that message. No response yet.

@piyushk
Copy link
Member

piyushk commented May 7, 2013

That's odd. I am pretty sure I signed up for ros-release. Maybe the request
has not been approved yet.

On Tue, May 7, 2013 at 11:07 AM, jack-oquin [email protected]:

I agree. We don't actually require them for freenect_camera.

Sometimes it would be useful to have some of those programs, perhaps for
testing or diagnosing problems. That's why I would consider packaging them
separately.

The libfreenect sourcedeb problem looks like something different to me.
Maybe just a build farm screw-up, or maybe something I did wrong during the
release cycle.

I asked about it on the ros-release ML:
https://code.ros.org/lurker/message/20130507.153722.2359b1de.en.html

I forgot to copy you on that message. No response yet.


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-17552007
.

@jack-oquin
Copy link
Member Author

Are those ros-release messages getting caught in a spam filter, perhaps?

As a package maintainer, you are supposed to subscribe.

If it's not working, contact @tfoote.

@tfoote
Copy link

tfoote commented May 7, 2013

@piyushk I don't see you on the list of subscribers.

@piyushk
Copy link
Member

piyushk commented May 7, 2013

The confirmation email for joining the list was going to spam, and I never
realized it. I should be signed up now.

On Tue, May 7, 2013 at 12:37 PM, Tully Foote [email protected]:

@piyushk https://github.com/piyushk I don't see you on the list of
subscribers.


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-17557493
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants