Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff_drive_controller: lifecycle checks in update method #1501

Open
christophfroehlich opened this issue Jan 21, 2025 · 0 comments
Open

diff_drive_controller: lifecycle checks in update method #1501

christophfroehlich opened this issue Jan 21, 2025 · 0 comments

Comments

@christophfroehlich
Copy link
Contributor

          This was in the old update() function and I kept it in because without it I failed tests (eg. "cleanup" in test_diff_drive_controller.cpp) that were calling update after deactivation. Whether or not to keep it depends on your philosophy: how much do you trust the external controller manager to not call update after deactivating the node?

Originally posted by @arthurlovekin in #1485 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant