Skip to content

Commit db01902

Browse files
committed
add different sleeps for better statistics testing
1 parent 11cada5 commit db01902

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

hardware_interface_testing/test/test_components/test_actuator.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ class TestActuator : public ActuatorInterface
143143
if (get_hardware_info().is_async)
144144
{
145145
std::this_thread::sleep_for(
146-
std::chrono::milliseconds(1000 / (3 * get_hardware_info().rw_rate)));
146+
std::chrono::milliseconds(1000 / (6 * get_hardware_info().rw_rate)));
147147
}
148148
// simulate error on write
149149
if (velocity_command_ == test_constants::WRITE_FAIL_VALUE)

hardware_interface_testing/test/test_components/test_system.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ class TestSystem : public SystemInterface
132132
if (get_hardware_info().is_async)
133133
{
134134
std::this_thread::sleep_for(
135-
std::chrono::milliseconds(1000 / (3 * get_hardware_info().rw_rate)));
135+
std::chrono::milliseconds(1000 / (6 * get_hardware_info().rw_rate)));
136136
}
137137
// simulate error on write
138138
if (velocity_command_[0] == test_constants::WRITE_FAIL_VALUE)

hardware_interface_testing/test/test_resource_manager.cpp

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1887,10 +1887,11 @@ class ResourceManagerTestReadWriteDifferentReadWriteRate : public ResourceManage
18871887
{
18881888
if (i > (cm_update_rate_ / rate))
18891889
{
1890-
const double expec_execution_time = (1.e6 / (3 * rate)) + 200.0;
1890+
const double expec_read_execution_time = (1.e6 / (3 * rate)) + 200.0;
1891+
const double expec_write_execution_time = (1.e6 / (6 * rate)) + 200.0;
18911892
EXPECT_LT(
18921893
status_map[component_name].read_statistics->execution_time.get_statistics().average,
1893-
expec_execution_time);
1894+
expec_read_execution_time);
18941895
EXPECT_LT(
18951896
status_map[component_name].read_statistics->periodicity.get_statistics().average,
18961897
1.2 * rate);
@@ -1903,7 +1904,7 @@ class ResourceManagerTestReadWriteDifferentReadWriteRate : public ResourceManage
19031904

19041905
EXPECT_LT(
19051906
status_map[component_name].write_statistics->execution_time.get_statistics().average,
1906-
expec_execution_time);
1907+
expec_write_execution_time);
19071908
EXPECT_LT(
19081909
status_map[component_name].write_statistics->periodicity.get_statistics().average,
19091910
1.2 * rate);
@@ -2292,29 +2293,30 @@ class ResourceManagerTestAsyncReadWrite : public ResourceManagerTest
22922293
if (check_for_updated_values)
22932294
{
22942295
const unsigned int rw_rate = 100u;
2295-
const double expec_execution_time = (1.e6 / (3 * rw_rate)) + 200.0;
2296+
const double expec_read_execution_time = (1.e6 / (3 * rw_rate)) + 200.0;
2297+
const double expec_write_execution_time = (1.e6 / (6 * rw_rate)) + 200.0;
22962298
check_periodicity(TEST_ACTUATOR_HARDWARE_NAME, rw_rate);
22972299
check_periodicity(TEST_SYSTEM_HARDWARE_NAME, rw_rate);
22982300
EXPECT_LT(
22992301
status_map[TEST_ACTUATOR_HARDWARE_NAME]
23002302
.read_statistics->execution_time.get_statistics()
23012303
.average,
2302-
expec_execution_time);
2304+
expec_read_execution_time);
23032305
EXPECT_LT(
23042306
status_map[TEST_ACTUATOR_HARDWARE_NAME]
23052307
.write_statistics->execution_time.get_statistics()
23062308
.average,
2307-
expec_execution_time);
2309+
expec_write_execution_time);
23082310
EXPECT_LT(
23092311
status_map[TEST_SYSTEM_HARDWARE_NAME]
23102312
.read_statistics->execution_time.get_statistics()
23112313
.average,
2312-
expec_execution_time);
2314+
expec_read_execution_time);
23132315
EXPECT_LT(
23142316
status_map[TEST_SYSTEM_HARDWARE_NAME]
23152317
.write_statistics->execution_time.get_statistics()
23162318
.average,
2317-
expec_execution_time);
2319+
expec_write_execution_time);
23182320
}
23192321
}
23202322

0 commit comments

Comments
 (0)