Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why use RCurl? #304

Closed
maelle opened this issue Oct 13, 2020 · 2 comments · Fixed by #307
Closed

Why use RCurl? #304

maelle opened this issue Oct 13, 2020 · 2 comments · Fixed by #307
Assignees
@Aariq
Labels
dependency Changed or broken dependency

Comments

@maelle
Copy link
Member

maelle commented Oct 13, 2020

We recommend not using RCurl https://devguide.ropensci.org/building.html#recommended-scaffolding

I was wondering what the use case for it is in webchem at the moment?
@Aariq Aariq added the dependency Changed or broken dependency label Oct 14, 2020
@Aariq
Copy link
Collaborator

Aariq commented Oct 14, 2020

I think it isn't actually used anymore and should be removed as a dependency.

@Aariq Aariq self-assigned this Oct 14, 2020
@Aariq
Copy link
Collaborator

Aariq commented Oct 14, 2020

related: #293

@Aariq Aariq mentioned this issue Oct 14, 2020
Merged
4 tasks
stitam added a commit that referenced this issue Feb 3, 2021
@stitam
Merge pull request #307 from Aariq/remove-rcurl
7857d26 
Closes #304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aariq Aariq

Labels
dependency Changed or broken dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed RCurl as a dependency Aariq/webchem
2 participants
@maelle @Aariq