Skip to content

Commit 3c96e9f

Browse files
committed
fix r cmd check Notes & cran submission
1 parent d2ab478 commit 3c96e9f

6 files changed

+17
-77
lines changed

.Rbuildignore

+2-9
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,9 @@
11
^.*\.Rproj$
22
^\.Rproj\.user$
3-
dev.r
43
README.html
54
README.Rmd
6-
.travis.yml
7-
autotest.Rexec
8-
ropenscience onboarding.md
9-
todo.txt
5+
README.md
106
logo/*.*
11-
_old_.travis.yml
12-
^cran-comments\.md$
13-
^\.travis\.yml$
14-
^codecov\.yml$
157
benchmarks
168
misc/*
179
revdep/*.*
@@ -21,3 +13,4 @@ revdep/*.*
2113
^Meta$
2214
^\.github$
2315
^CRAN-SUBMISSION$
16+
^cran-comments\.md$

CRAN-SUBMISSION

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
Version: 0.7.14
2-
Date: 2024-08-24 11:06:20 UTC
3-
SHA: 855bbe6df84db6b13da27c786ec58fd746250682
1+
Version: 0.7.15
2+
Date: 2024-08-24 13:03:06 UTC
3+
SHA: d2ab4788e97bfad0a6e7b7a7c3b70938be954a5e

DESCRIPTION

+2-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Package: robotstxt
22
Date: 2024-08-24
33
Type: Package
44
Title: A 'robots.txt' Parser and 'Webbot'/'Spider'/'Crawler' Permissions Checker
5-
Version: 0.7.14
5+
Version: 0.7.15
66
Authors@R: c(
77
person(
88
"Pedro", "Baltazar", role = c("aut", "cre"),
@@ -31,7 +31,6 @@ Imports:
3131
stringr (>= 1.0.0),
3232
httr (>= 1.0.0),
3333
spiderbar (>= 0.2.0),
34-
future (>= 1.6.2),
3534
future.apply (>= 1.0.0),
3635
magrittr,
3736
utils
@@ -45,5 +44,5 @@ Suggests:
4544
Depends:
4645
R (>= 3.0.0)
4746
VignetteBuilder: knitr
48-
RoxygenNote: 7.1.1
47+
RoxygenNote: 7.2.3
4948
Encoding: UTF-8

NEWS.md

+7
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
NEWS robotstxt
22
==========================================================================
33

4+
0.7.15 | 2024-08-24
5+
--------------------------------------------------------------------------
6+
7+
- CRAN compliance - Packages which use Internet resources should fail gracefully
8+
- CRAN compliance - fix R CMD check NOTES.
9+
10+
411
0.7.14 | 2024-08-24
512
--------------------------------------------------------------------------
613

R/rt_get_fields.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ rt_get_fields <- function(txt, regex = "", invert = FALSE){
8484

8585
# ensuring chracter columns
8686
for( i in seq_len(dim(df)[2]) ){
87-
if( class(df[,i]) == "factor" ){
87+
if( is.factor(df[,i]) ){
8888
df[,i] <- as.character(df[,i])
8989
}
9090
}

cran-comments.md

+2-61
Original file line numberDiff line numberDiff line change
@@ -1,64 +1,5 @@
1-
This is a re-submission.
2-
3-
## Your comments
4-
5-
You still have not followed the moved content in
6-
7-
Found the following (possibly) invalid URLs:
8-
URL: https://contributor-covenant.org/ (moved to
9-
https://www.contributor-covenant.org/)
10-
From: README.md
11-
Status: 200
12-
Message: OK
13-
URL: https://contributor-covenant.org/version/1/0/0/ (moved to
14-
https://www.contributor-covenant.org/version/1/0/0/)
15-
From: README.md
16-
Status: 200
17-
Message: OK
18-
19-
Please fix and resubmit.
20-
21-
22-
23-
24-
## My actions
25-
26-
I changed the URLs.
27-
28-
Sorry, that this is such a mess - I am really trying to get them fixed and
29-
minimize workload on behalf of CRAN.
30-
31-
(HTTP 301 forwards are however also a very common in the ever changing internet
32-
and in contrast to 4xx and 5xx HTTP status codes no errors as such -
33-
"301 moved permanetly" can mean anything really including any kind of
34-
redirect for any reason.
35-
It would be great if those test would be
36-
part of the normal R CMD check?. ...So I (and all the others)
37-
can fetch them locally or via the CI pipelines set up and ready to catch problems
38-
beforhand).
39-
40-
41-
42-
43-
44-
## Test environments
45-
46-
- Ubuntu precise (16.04) (on travis-ci: old, current, devel; https://travis-ci.org/github/ropensci/robotstxt ) --> OK
47-
48-
- Win10 lokal with R 3.6.3 --> OK
49-
- win-builder - devel --> OK
50-
- win-builder - release --> OK
51-
52-
531
## R CMD check results
542

55-
0 errors | 0 warnings | 0 notes
56-
57-
58-
59-
## Reverse Dependency Checks
60-
61-
Seems ok.
62-
63-
3+
0 errors | 0 warnings | 0 note
644

5+
* fixing all checks problems

0 commit comments

Comments
 (0)