Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srr bug #41

Closed
mpadge opened this issue Aug 26, 2024 · 1 comment
Closed

srr bug #41

mpadge opened this issue Aug 26, 2024 · 1 comment

Comments

@mpadge
Copy link
Member

mpadge commented Aug 26, 2024

ropensci/software-review#615, which dumps stderr log:

Error in gsub(fpath, paste0(dir, "/", block$file) : invalid 'pattern' argument
@mpadge mpadge closed this as completed in 9e259b9 Aug 26, 2024
@mpadge
Copy link
Member Author

mpadge commented Aug 27, 2024

Re-opening because of ropensci/software-review#615 (comment), in which @osorensen documented standards in tests/testthat.R. The above commit included this code:

srr/R/roclet.R

Lines 244 to 248 in 1242fef

if (length (fpath) == 0L) {
# Mostly only for 'tests/testthat.R' file, which should never have tags
# anyway, so is skipped here.
return (NULL)
}

Have to revert that commit and resolve this bug another way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant