Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"editor.css" not included when Gutenberg (block) editor is in the new iframe mode #3185

Open
mjsarfatti opened this issue Apr 12, 2024 · 1 comment
Labels

Comments

@mjsarfatti
Copy link

Version

10.8.2

What did you expect to happen?

The new Gutenberg (block) editor is now inside an iframe. For this reason enqueueing editor assets using the enqueue_block_editor_assets hook no longer works reliably, and we are recommended to use enqueue_block_assets instead (see: https://github.com/WordPress/gutenberg/blob/trunk/docs/how-to-guides/enqueueing-assets-in-the-editor.md#editor-content-scripts-and-styles).

I expect styles in editor.css to be applied when the editor appears inside an iframe and I use the enqueue_block_assets hook.

What actually happens?

Styles in editor.css are not applied in the following two cases:

  1. When using the enqueue_block_editor_assets hook if the editor appears inside an iframe, or
  2. When using the enqueue_block_assets hook both when the editor appears inside an iframe and when it appears in page (legacy).

Steps to reproduce

  1. Do a fresh install of Bedrock+Acorn+Sage and activate the Sage theme
  2. Edit the file web/app/themes/sage-theme/app/setup.php like so:
- add_action('enqueue_block_editor_assets', function () {
+ add_action('enqueue_block_assets', function () { 
  1. Add some CSS to editor.css, for example:
.wp-block {
  background: pink;
}
  1. Go to edit a page, and see that the background is not applied

System info

No response

Log output

No response

Please confirm this isn't a support request.

Yes

@mjsarfatti mjsarfatti added the bug label Apr 12, 2024
@retlehs
Copy link
Member

retlehs commented Sep 19, 2024

Both editor CSS and JS are working as expected for me with enqueue_block_editor_assets and enqueue_block_assets

When using the current hook (enqueue_block_editor_assets) there is this warning:

editor/0-css was added to the iframe incorrectly. Please use block.json or enqueue_block_assets to add styles to the iframe.

I'll get a PR up with that change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants