Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build failure with mysql 8.3 #14376

Closed
1 task done
bevanjkay opened this issue Jan 17, 2024 · 1 comment · Fixed by #14378
Closed
1 task done

build failure with mysql 8.3 #14376

bevanjkay opened this issue Jan 17, 2024 · 1 comment · Fixed by #14378
Labels
bug

Comments

@bevanjkay
Copy link

Check duplicate issues.

  • Checked for duplicates

Description

Hi 👋,
Homebrew maintainer here. We are trying to build root with the 8.3.0 release of MySQL, but we are seeing a build error to an API deprecation - https://dev.mysql.com/doc/relnotes/mysql/8.3/en/news-8-3-0.html#mysqld-8-3-0-deprecation-removal

Reproducer

2024-01-17T12:50:08.5969830Z /tmp/root-20240117-14093-76plq7/root-6.30.02/sql/mysql/src/TMySQLServer.cxx:642:16: error: use of undeclared identifier 'mysql_reload'
2024-01-17T12:50:08.5970520Z    Int_t res = mysql_reload(fMySQL);
2024-01-17T12:50:08.5970770Z                ^
2024-01-17T12:50:08.5971380Z /tmp/root-20240117-14093-76plq7/root-6.30.02/sql/mysql/src/TMySQLServer.cxx:661:10: error: use of undeclared identifier 'mysql_shutdown'
2024-01-17T12:50:08.5972100Z    res = mysql_shutdown(fMySQL, SHUTDOWN_DEFAULT);
2024-01-17T12:50:08.5972430Z          ^
2024-01-17T12:50:08.5972600Z 2 errors generated.

ROOT version

Installation method

build from source

Operating system

Additional context

Homebrew/homebrew-core#160037
@bevanjkay bevanjkay added the bug label Jan 17, 2024
@bevanjkay bevanjkay mentioned this issue Jan 17, 2024
Merged
6 tasks
ferdymercury added a commit to ferdymercury/root that referenced this issue Jan 18, 2024
@ferdymercury
[sql] alternative for deprecated or removed methods
3ef10c8 
Fixes root-project#14376

See https://dev.mysql.com/doc/relnotes/mysql/8.3/en/news-8-3-0.html#mysqld-8-3-0-deprecation-removal
@ferdymercury ferdymercury mentioned this issue Jan 18, 2024
Merged
2 tasks
@ferdymercury
Copy link
Contributor

Fix proposed here: #14378

linev pushed a commit that referenced this issue Jan 18, 2024
@ferdymercury
[mysql] alternative for deprecated or removed methods in v8 (#14378)
d6b6a73 
* [sql] alternative for deprecated or removed methods

Fixes #14376

See https://dev.mysql.com/doc/relnotes/mysql/8.3/en/news-8-3-0.html#mysqld-8-3-0-deprecation-removal

* fix syntax
linev pushed a commit to linev/root that referenced this issue Jan 18, 2024
@ferdymercury @linev
[mysql] alternative for deprecated or removed methods in v8 (root-pro…
5f06f52 
…ject#14378)

* [sql] alternative for deprecated or removed methods

Fixes root-project#14376

See https://dev.mysql.com/doc/relnotes/mysql/8.3/en/news-8-3-0.html#mysqld-8-3-0-deprecation-removal

* fix syntax
@linev linev mentioned this issue Jan 18, 2024
Merged
linev pushed a commit that referenced this issue Jan 19, 2024
@ferdymercury @linev
[mysql] alternative for deprecated or removed methods in v8 (#14378)
560a615 
* [sql] alternative for deprecated or removed methods

Fixes #14376

See https://dev.mysql.com/doc/relnotes/mysql/8.3/en/news-8-3-0.html#mysqld-8-3-0-deprecation-removal

* fix syntax
vgvassilev pushed a commit to vgvassilev/root that referenced this issue Feb 8, 2024
@ferdymercury @vgvassilev
[mysql] alternative for deprecated or removed methods in v8 (root-pro…
d28ed73 
…ject#14378)

* [sql] alternative for deprecated or removed methods

Fixes root-project#14376

See https://dev.mysql.com/doc/relnotes/mysql/8.3/en/news-8-3-0.html#mysqld-8-3-0-deprecation-removal

* fix syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mysql] alternative for deprecated or removed methods in v8 ferdymercury/root
2 participants
@ferdymercury @bevanjkay