Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jupyter kernels for C++20 and C++2b (Nb: C++2b is a working draft of C++23) #15245

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

dbonner
Copy link
Contributor

@dbonner dbonner commented Apr 16, 2024

Changes or fixes:

I built from source using the default "ROOT-llvm16" branch of root-project/llvm-project. I didn't have to do much work to allow the creation of updated Jupyter kernels (C++20 and C++2b). I thought I might as well share the result. All the best, Daniel.

(Nb: I moved this pull request from the root/cling mirror site as suggested by @ferdymercury )

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

Copy link

Test Results

    10 files      10 suites   2d 0h 17m 8s ⏱️
 2 623 tests  2 623 ✅ 0 💤 0 ❌
24 778 runs  24 778 ✅ 0 💤 0 ❌

Results for commit 809c1bd.

Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@girdevstack
Copy link

Hi - any ETA on getting this merged? @dbonner @vgvassilev

@vgvassilev
Copy link
Member

Can you rebase this PR?

@dpiparo dpiparo merged commit 8459a34 into root-project:master Oct 19, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

please add jupyter kernel for c++20
5 participants