Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booking common errors #566

Open
kkolotyuk opened this issue Nov 22, 2016 · 0 comments
Open

Booking common errors #566

kkolotyuk opened this issue Nov 22, 2016 · 0 comments

Comments

@kkolotyuk
Copy link
Contributor

Bridge API uses concierge to handle booking requests. In this case we don't have guarantees that a client every time before booking request sends quote request (as Roomorama does), so Concierge should be ready to validate all the common errors from quote scenario + common errors from booking scenario during booking request. Here is a list of possible errors during booking request I could found for some suppliers.

Ciirus:

MakeBooking: Error - Arrival Date must be >= today
MakeBooking: Error - Departure Date must be >= tomorrow
MakeBooking: Error - Departure Date must be >= Arrival Date
Another reservation already exists overlapping your selected dates 1
Error placing booking

JTB:

Invalid check-in date
Invalid check-out date
Check-in date should be earlier than Check-out date.
Maximum length of stay must be less than 15 nights.
No Available Inventory.
Unable to check-in on the specified day.
Your request is shorter than the minimum stay.

RU:

Property is not available for a given dates
Dates mishmash
Past dates
The reservation was created by the other user
Property does not exist
DateFrom has to be earlier than DateTo.
DateFrom has to be earlier or equal to DateTo.
Number of guests exceedes the maximum allowed.
Stay period doesn't match with minimum stay

From this list I suggest to extract several common error codes for booking webhook as we did for quote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant