Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kigo requests #469

Open
kkolotyuk opened this issue Oct 19, 2016 · 0 comments
Open

Kigo requests #469

kkolotyuk opened this issue Oct 19, 2016 · 0 comments
Labels

Comments

@kkolotyuk
Copy link
Contributor

Kigo and Kigo Legacy have different credentials but Kigo::LegacyRequest#builder creates Kigo::Request instance and passes there legacy's credentials. This credentials is not used inside the Kigo::Request but this is confusing situation.

Kigo::LegacyRequest#builder uses Kigo::Request as builder. My suggestion is to extract this builder in separate class and don't create Kigo::Request inside Kigo::LegacyRequest.

After this refactoring we could extract usage of Hanami.env from Kigo supplier as discussed #461 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants