You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Kigo and Kigo Legacy have different credentials but Kigo::LegacyRequest#builder creates Kigo::Request instance and passes there legacy's credentials. This credentials is not used inside the Kigo::Request but this is confusing situation.
Kigo::LegacyRequest#builder uses Kigo::Request as builder. My suggestion is to extract this builder in separate class and don't create Kigo::Request inside Kigo::LegacyRequest.
After this refactoring we could extract usage of Hanami.env from Kigo supplier as discussed #461 (review)
The text was updated successfully, but these errors were encountered:
Kigo and Kigo Legacy have different credentials but
Kigo::LegacyRequest#builder
createsKigo::Request
instance and passes there legacy's credentials. This credentials is not used inside theKigo::Request
but this is confusing situation.Kigo::LegacyRequest#builder
usesKigo::Request
as builder. My suggestion is to extract this builder in separate class and don't createKigo::Request
insideKigo::LegacyRequest
.After this refactoring we could extract usage of
Hanami.env
from Kigo supplier as discussed #461 (review)The text was updated successfully, but these errors were encountered: