Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every non-tag build should be a SNAPSHOT #30

Open
vmatare opened this issue May 4, 2021 · 0 comments
Open

Every non-tag build should be a SNAPSHOT #30

vmatare opened this issue May 4, 2021 · 0 comments

Comments

@vmatare
Copy link

vmatare commented May 4, 2021

First of all, thanks for this plugin, the premise of which I completely agree with. However I'm a little confused by the way SNAPSHOT builds are apparently supposed to happen. As I understand it, to get a SNAPSHOT build (as per the maven convention), I'd have to explicitly make a git version tag with the word -SNAPSHOT in it. However that's logically a contradiction to me. A snapshot by definition is simply the tip of whatever is currently in development. That's why we want to have the shorthash in the version string after all, and thank god lein-v understands this.

So what (I think) I'd like to have is the ability to have lein-v simply insert -SNAPSHOT in the version string if-and-only-if a shorthash is in the version string (seems to me these two cases are exactly equivalent).

The behavior I want to get in the end is for lein deploy to always use the correct repository, and as I understand it, the (hardcoded) convention there is the :snapshots repo if -SNAPSHOT is in the version string, and the :releases repo otherwise. This is documented slightly confusingly here: https://github.com/technomancy/leiningen/blob/stable/doc/DEPLOY.md#deploying-to-maven-central

Apologies if this is already possible somehow and I overlooked it ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant