Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:v {:prefix "foo"} value in project.clj does not affect 'lein v' #25

Open
timgilbert opened this issue Aug 7, 2018 · 1 comment
Open

Comments

@timgilbert
Copy link
Contributor

Hi, it's me again! ;)

I'm experimenting with the prefix stuff - my use case is I have a legacy branch that I'd like to manage with a series of legacy-0.3.2 tags while mainline continues along with the usual v1.2.3 tags. It seems like putting :v {:prefix "legacy-"} in my project.clj should work for this, but it doesn't have any effect when I run lein v.

I started a PR for this, thinking it would be an easy fix, but then I realized I still have no idea how midje is supposed to work and all the tests failed. Anyways, the root of the fix is this small diff:

timgilbert@829596b

I can keep hacking on the tests, just thought I would run it by you first.

@timgilbert timgilbert changed the title :v {:prefix "foo"} value in project.clj does not effect 'lein v' :v {:prefix "foo"} value in project.clj does not affect 'lein v' Nov 6, 2018
@knorrest
Copy link

Look like I just did (almost) the same thing you did: #31 before seeing this. My hopes for getting this fixed quickly suddenly dropped... To me this problem means the plugin is basically unusable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants