Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubyzip 3.0 breaking changes breaking roo #621

Open
broksonic21 opened this issue Jan 8, 2025 · 0 comments
Open

Rubyzip 3.0 breaking changes breaking roo #621

broksonic21 opened this issue Jan 8, 2025 · 0 comments

Comments

@broksonic21
Copy link

Steps to reproduce

  1. Spreadsheet: https://github.com/roo-rb/roo/files/2377084/Book2.xlsx
  2. Code: https://gist.github.com/broksonic21/5f479441e18be4102012d0e2ec0d59fe
  3. Call it with this:

RUBYZIP_V3_API_WARN=1 ruby a.rb

Issue

After Rubyzip 2.4 came out, they are warning about v3 incompatible changes. See: https://github.com/rubyzip/rubyzip/wiki/Updating-to-version-3.x

We get this warnings:

# Running:

You have called 'Zip::Entry#extract' (from excelx.rb:336).
This method is changing or deprecated in version 3.0.0. Please see
  https://github.com/rubyzip/rubyzip/wiki/Updating-to-version-3.x
for more information.
You have called 'Zip::Entry#extract' (from excelx.rb:360).
This method is changing or deprecated in version 3.0.0. Please see
  https://github.com/rubyzip/rubyzip/wiki/Updating-to-version-3.x
for more information.
You have called 'Zip::Entry#extract' (from excelx.rb:381).
This method is changing or deprecated in version 3.0.0. Please see
  https://github.com/rubyzip/rubyzip/wiki/Updating-to-version-3.x
for more information.
You have called 'Zip::Entry#extract' (from excelx.rb:381).
This method is changing or deprecated in version 3.0.0. Please see
  https://github.com/rubyzip/rubyzip/wiki/Updating-to-version-3.x
for more information.
You have called 'Zip::Entry#extract' (from excelx.rb:465).
This method is changing or deprecated in version 3.0.0. Please see
  https://github.com/rubyzip/rubyzip/wiki/Updating-to-version-3.x
for more information.
You have called 'Zip::Entry#extract' (from excelx.rb:465).
This method is changing or deprecated in version 3.0.0. Please see
  https://github.com/rubyzip/rubyzip/wiki/Updating-to-version-3.x
for more information.

System configuration

Roo version: 2.10.1
RubyZip version: 2.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant