-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popup is not closing #134
Comments
Yes, your redirect URI should equal the configured redirect URI (or the origin uri if you've not configured it in the provider) |
another common issue is that you have a redirect that does not preserve the query params and then the code cannot catch the query params on time. you'll have to use a non-redirected redirect in order for the popup to close. |
Thanks for your anwsers (I will have a look later) |
Any developments on this issue? |
Not yet and not soon, sorry :/ |
Hi In the 8.0.1 version, if I don't set the redirectUri, I have the same behavior as the previous version, but the post params brake the compatibility with the server. |
I am not getting popup page. Instead I am getting a new page instead when I do Any tip on how I can get the page to show as a popup? |
@tuhin24 what's your environment? what configuration you use? what is the "type"? |
Popup doesn't close on Edge. Angular 6. |
Just tested it, works for me. |
What version of the Edge have you tried it with? It works on Windows Edge <44 without any issues. However, it does fail on Edge 44 for me as well. Looks like Edge throws
here
|
Hi there,
I have an issue when I use the
authenticate('google')
ofAuthService
.When I trigger the button, the popup opens. Then, I connect my google accout and I am redirected to my server. Finally, I get a
200
from my server. But the popup doesn't closes itself.Note : If I manually close the window, I get the error :
Authentication Canceled
.What are the conditions for the popup to close itself ?
Here is the code :
I guess that the solution is here : https://github.com/ronzeidman/ng2-ui-auth/blob/master/src/popup.service.ts#L89
It seems to me that, in order that the popup closes itself, the configured redirect URI have to be the same that the location of the window. Am I right ?
Thanks for your work
The text was updated successfully, but these errors were encountered: