Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making ast module public? #1

Open
ratmice opened this issue May 31, 2022 · 1 comment
Open

making ast module public? #1

ratmice opened this issue May 31, 2022 · 1 comment

Comments

@ratmice
Copy link

ratmice commented May 31, 2022

One thing I noticed is that ron_reboot::utf8_parser::ast_from_str is public, but the Ron<'_> value return type is from the private module ron_reboot::ast. I don't have a great understanding of rust visibility, but it appears the behavior is such that you can access public fields of the Ron<'_> value, but can't pattern match over them.

It would be nice for accessing spans, if you could pattern match over the ron.expr therein.
Is there a reason the module isn't public?

@torkleyy
Copy link
Contributor

torkleyy commented Jun 3, 2022

That seems like it was an oversight, but if you're going to use this repo you're better off cloning and modifying it, I never finished it - there's a major performance issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants