Skip to content

DataGrid DataPoint DataBlob Inheritance #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benjaminleighton opened this issue May 7, 2025 · 2 comments
Open

DataGrid DataPoint DataBlob Inheritance #163

benjaminleighton opened this issue May 7, 2025 · 2 comments
Assignees

Comments

@benjaminleighton
Copy link
Collaborator

@pbranson noticed that DataPoint (and thus indirectly DataGrid) inherit from DataBlob and we are unsure why this is the case. He has fixed this in https://github.com/rom-py/rompy/pull/159/files however there are some other changes there I am reviewing but if you @rafa-guedes or @tomdurrant could take a look specifically at the inheritance issue that would be good.

@rafa-guedes
Copy link
Collaborator

True, they don't really need to inherit from DataBlob - I suggest we define a base, abstract class DataBase just defining the common fields (model_type / id) and the basic api (the get method), and used it with both DataBlob and DataPoint. Would that work?

@rafa-guedes
Copy link
Collaborator

rafa-guedes commented May 7, 2025

@benjaminleighton I have removed the dependency of DataPoint/Grid on DataBlob, and added a new abstract base class that is very simple and just defines common fields and the basic get signature, in #164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants