Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

[Feature Request][design]: DA error handling #73

Open
tuxcanfly opened this issue Feb 9, 2024 · 2 comments
Open

[Feature Request][design]: DA error handling #73

tuxcanfly opened this issue Feb 9, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@tuxcanfly
Copy link
Collaborator

tuxcanfly commented Feb 9, 2024

Implementation ideas

This is a design discussion to coordinate error handling between celestia core/app and rollup clients like rollkit.

Some issues with the current model

Overall this makes handling DA submission challenging because of the lack of congest control flow and lack of dynamic fee market.

@tuxcanfly tuxcanfly added the enhancement New feature or request label Feb 9, 2024
@tuxcanfly tuxcanfly self-assigned this Feb 12, 2024
@zmanian
Copy link

zmanian commented Feb 13, 2024

These issues seem broadly related the general "comet BFT mempool does not accommodate the application specific requirements" issue.

I surfaced these issues to the comet BFT mempool working group.

  1. The mempool doesn't support "contracts" like replace by fee. It's just a dumb queue.

  2. Ante handlers are ignorant of "whole block" construction factors and can get stuck in head of the line blocking issues where a tx can't be proposed but also blocks the queue. Block construction needs be able to generate a more complex view into the mempool than ReapMaxBytes allows.

Binary Builders has indicated they are building capabilities into server v2 that would enable these kinds of features but would be good to align on an overall technical approach.

@zmanian
Copy link

zmanian commented Feb 13, 2024

Relevant

cosmos/cosmos-sdk#19329

@Manav-Aggarwal Manav-Aggarwal moved this to In Progress in Rollkit Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants