Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: telescope integration #262

Draft
wants to merge 5 commits into
base: release/v0.50
Choose a base branch
from
Draft

feat: telescope integration #262

wants to merge 5 commits into from

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Oct 30, 2024 •
edited
Loading

closes #256

Summary

Add a good UX for telescope to generate proto files -> ts files.

A single make command should handle all the install, generation, etc for a good client

image

@Reecepbcups
Copy link
Member Author

Issues rn

lots of is missing the following properties from type 'TsProtoGeneratedType': fromJSON, toJSON for a ton of types (ibc, custom module, cosmos, etc)

@Reecepbcups
Copy link
Member Author

Reecepbcups commented Oct 30, 2024 •
edited
Loading

ref cosmology-tech/telescope#525 does not seem to work either on latest version 1.10.6. It keeps being overriden when I run the telescope binary, despite it being in the same directory. Why would it do that

@Reecepbcups
Copy link
Member Author

Okay got past a bunch of the errors. You have to specify telescope transpile --protoDirs=./proto --outPath=./src/codegen --config .telescope.json with the config, else it will override (instead of using it for some reason, maybe it should prompt instead like 'hey btw i am going to override your config' ?)

@Reecepbcups
Copy link
Member Author

global search to the previous proto dir would be nice

telescope transpile --protoDirs=./proto,../proto/* --outPath=./src/codegen --config ../.telescope.json

else I have to cp -r the proto from my root -> the proto, kinda bad ux

Reecepbcups
Reecepbcups commented Oct 30, 2024
View reviewed changes
simapp/README.md

telescope install @protobufs/tendermint @protobufs/ibc @protobufs/google @protobufs/gogoproto @protobufs/cosmos_proto @protobufs/cosmos

cp -r ../proto/* ./proto # I dislike this step, why? Can't I use the parent package for my custom modules, but then relative for the installed ones?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would require glob check support within the string[] type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

telescope integration
1 participant
@Reecepbcups