"Go to Presets" error

[renegade304]

The "Go to Presets" command does not work on positions 0 - 9, even though they are saved. Preset numbers 10 - 14 work correctly.

[roleoroleo]

10-14 are predefined presets.
Check if your presets are properly saved:
cat /mnt/mmc/sonoff-hack/etc/ptz_presets.conf

[renegade304]

The file content looks like this:

0=Start|2364|-102
1=OK|2329|-182
2=Domka|2632|-182
3=Nelka|2053|-412
4=empty|-1|-1
5=empty|-1|-1
6=empty|-1|-1
7=empty|-1|-1
8=empty|-1|-1
9=empty|-1|-1

[roleoroleo]

Mmmmh
Negative numbers are not allowed.
ptz binary discards them.
Please try to set presets again.

[renegade304]

I tried - it was saved as a negative number again.
When I manually deleted the minus - the preset location setting worked.
It looks like an error while saving the preset.

[roleoroleo]

When the camera starts up, does it do a full pan and tilt?

[flreinhard]

I think, there's a bug in ptz.c

sonoff-hack/src/ptz/ptz/ptz.c

Lines 572 to 577 in f83fcd8

	if (x < MIN_X) x = MIN_X;
	if (x > MAX_X) x = MAX_X;
	if (y < MIN_Y) y = MIN_Y;
	if (y < MAX_Y) y = MAX_Y;
	x = preset_buffer[3];
	y = preset_buffer[4];

I think it should be

        x = preset_buffer[3];
        y = preset_buffer[4];
        if (x < MIN_X) x = MIN_X;
        if (x > MAX_X) x = MAX_X;
        if (y < MIN_Y) y = MIN_Y;
        if (y < MAX_Y) y = MAX_Y;

otherwise your limits to min(0) and max won't work.

@roleoroleo: why do you limit to 0 when /dev/ptz delivers negative numbers?

[flreinhard]

@renegade304 you could give my changes a try. you can download a file at the bottom here: https://github.com/roleoroleo/sonoff-hack/actions/runs/13616982538