Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/resolve and reject can cause node creation #21

Merged

Conversation

chrisdp
Copy link
Contributor

@chrisdp chrisdp commented Aug 22, 2024

No description provided.

@chrisdp chrisdp added the bug Something isn't working label Aug 22, 2024
@chrisdp chrisdp requested a review from TwitchBronBron August 22, 2024 17:39
@chrisdp chrisdp self-assigned this Aug 22, 2024
@TwitchBronBron TwitchBronBron added the create-package create a temporary npm package on every commit label Aug 22, 2024
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Great catch!

@rokucommunity-bot
Copy link

Hey there! I just built a new temporary npm package based on e406460. You can download it here or install it by running the following command:

npm install https://github.com/rokucommunity/promises/releases/download/v0.0.0-packages/rokucommunity-promises-0.2.0-bugfix-resolve-and-reject-can-cause-node-creation.20240822195922.tgz

@TwitchBronBron TwitchBronBron marked this pull request as ready for review August 23, 2024 15:37
@rokucommunity-bot
Copy link

Hey there! I just built a new temporary npm package based on d165368. You can download it here or install it by running the following command:

npm install https://github.com/rokucommunity/promises/releases/download/v0.0.0-packages/rokucommunity-promises-0.2.0-bugfix-resolve-and-reject-can-cause-node-creation.20240823161621.tgz

@rokucommunity-bot
Copy link

Hey there! I just built a new temporary npm package based on 231ebb4. You can download it here or install it by running the following command:

npm install https://github.com/rokucommunity/promises/releases/download/v0.0.0-packages/rokucommunity-promises-0.2.0-bugfix-resolve-and-reject-can-cause-node-creation.20240823163654.tgz

@TwitchBronBron TwitchBronBron merged commit d8b20dd into master Aug 23, 2024
3 checks passed
@TwitchBronBron TwitchBronBron deleted the bugfix/resolve-and-reject-can-cause-node-creation branch August 23, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working create-package create a temporary npm package on every commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants