Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added worldtext_menu. (ScreenMenu) #772

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

T3Marius
Copy link

@T3Marius T3Marius commented Feb 9, 2025

I've added ScreenMenu to MenuManager.

It works same as CenterHtmlMenu and has the necessary checks and clears thanks to Poggu.

I don't know if it's a problem so i've made it confiugrable but i've added the Create function in CreateScreenMenu.cs where people can create hud text if they set the isMenu to false and when isMenu is true it adds a backround to the text.

Only things that are need to be done in my opinion are using the spectating player viewmodel to acces the menu while spectating players. For those in spectator team or free cam i don't have any idea.

[W/S] to scroll and [E] to select.

@T3Marius T3Marius requested a review from roflmuffin as a code owner February 9, 2025 21:18
@Dliix66
Copy link

Dliix66 commented Feb 11, 2025

Can you remove your formatting? This makes the PR hard to read 😅

@T3Marius
Copy link
Author

Can you remove your formatting? This makes the PR hard to read 😅

Should i show only what i've changed?

@roflmuffin
Copy link
Owner

My gut feeling is that this implementation is a little too involved to go into the core of CS# and might be better off as a library published on nuget

@T3Marius
Copy link
Author

My gut feeling is that this implementation is a little too involved to go into the core of CS# and might be better off as a library published on nuget

Got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants