Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CenterHtmlMenu Open method in a weird state. #395

Closed
frederikstonge opened this issue Apr 3, 2024 · 1 comment · Fixed by #396
Closed

CenterHtmlMenu Open method in a weird state. #395

frederikstonge opened this issue Apr 3, 2024 · 1 comment · Fixed by #396
Labels
untriaged New issue has not been triaged

Comments

@frederikstonge
Copy link
Contributor

Not really an issue, but something is missing here in the new CenterHtmlMenu change to support Open method.
image

IMO, we should either remove the constructor without the BasePlugin :
image

OR, throw an exception if the BasePlugin is null to inform the user that he has used the wrong constructor :

image
@github-actions github-actions bot added the untriaged New issue has not been triaged label Apr 3, 2024
roflmuffin added a commit that referenced this issue Apr 3, 2024
@roflmuffin
fix: mark constructor as obsolete, throw error
2ffed0b 
closes #395
@roflmuffin roflmuffin mentioned this issue Apr 3, 2024
Merged
@roflmuffin
Copy link
Owner

I agree, I almost requested this as a CR in the PR but decided against it but I think throwing the exception makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
untriaged New issue has not been triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: mark center html menu constructor as obsolete, throw error roflmuffin/CounterStrikeSharp
2 participants
@roflmuffin @frederikstonge