Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing client_options to S3 object store #1

Open
cabrrtt opened this issue Feb 1, 2023 · 3 comments
Open

passing client_options to S3 object store #1

cabrrtt opened this issue Feb 1, 2023 · 3 comments

Comments

@cabrrtt
Copy link

cabrrtt commented Feb 1, 2023

Hi @roeap
I came here after reading this ticket on the arrow-datafusion-python repo. I have a question on the S3 ObjectStore and whether it is possible to pass ClientOptions struct to Rust through the python bindings?

@roeap
Copy link
Owner

roeap commented Feb 1, 2023

Hey @cabrrtt, some of the storage otions end up as client options, but most are currently not passed down.

That said, it would be quite easy to add that. Would you expect to pass this as part of the current storage options, or in a separate map? ALso would you care about configuring retry options, which are internally handled separately?

@cabrrtt
Copy link
Author

cabrrtt commented Feb 1, 2023

Good questions! It's probably a question of what is the most pythonic approach. In my case I wish to pass a map of arbitrary headers down to ClientOptions, and for that a dict is the most natural route I believe.

Regarding retry, I think this is also necessary. Does it make sense to follow the same signature as the Rust api, as a nested dict?

retry_config = {
  "max_retries": int,
  "retry_timeout": int ms,
  "backoff": {
    "init_backoff": int ms,
    "max_backoff": int ms,
    "base": float
  }
}

@cabrrtt
Copy link
Author

cabrrtt commented Feb 1, 2023

I think logically this would mean if it were to follow the Rust api, for headers:

default_headers: {
   "x-amz-meta-...": string,
   ...
}

though ergonomically this feels better named just headers(?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants