Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-screen with non-uniform orientation and wallpaper centering problem #2326

Open
6 tasks
Raf-UJ opened this issue Jul 24, 2024 · 2 comments
Open
6 tasks
Labels
enhancement New feature or request

Comments

@Raf-UJ
Copy link

Raf-UJ commented Jul 24, 2024

Short version:

Problem people like me are having with two or more screens not being aligned that's relatively easy to fix :
resizing the overall resolution of all of the screens combined and allowing for shifting the center.

I am aware that not everyone will fall into this category but going off of a premise that many people would gain from this and also a quick way of "re-cropping" the wallpaper functionality that enhances customisation it's worth looking at. There's a minor bug as well.

Example: Digital Designer dual screen setup

Screenshot 2024-07-24 101948 (Custom)

Because of the screen mount I can't have it aligned "to the top edge" so I have to align them centrally. That's not an issue unless I have a wallpaper that has the central composition..

Screenshot 2 (Custom)

What could this look like for others:

here are the examples of the setup that would NOT work for wallpapers with centralised composition
Multiscreen alignment issue-01-01

and with simple visualisation:
Multiscreen alignment issue-01

with this particular wallpaper we can get away with it but a character that's a side-heavy composition will get cropped.

Solution

  • implement functions to calculate overall size of the "canvas"
  • implement function that will allow for shifting the canter by offsetting the entire "canvas"
  • implement sliders for both horizontal and vertical shift separately
  • Nice-to-have's:
    • tickbox for antialiased scaling "Enable safe scaling" (keeping the jump in ×4pix increments or maybe even something more complex with performance options in mind (light/heavy))
    • option to save the shift permanently
    • option to shift each screen separately via canvas duplication (this could be very heavy)

Bug

picking up the shared wallpaper changes the preview of the screen

Capture
Capture1

log file:
lively_log_20240724_105301.zip

@Raf-UJ Raf-UJ added the enhancement New feature or request label Jul 24, 2024
@rocksdanister rocksdanister changed the title ▬▋✜ Multi-screen with non-uniform orientation and wallpaper centering problem Multi-screen with non-uniform orientation and wallpaper centering problem Jul 24, 2024
@rocksdanister
Copy link
Owner

rocksdanister commented Jul 24, 2024

Personally I do not like adding sliders and too many configuration to the interface and instead try to keep things simple, will see what can be done (the visuals help, ty) but not a priority at the moment.

picking up the shared wallpaper changes the preview of the screen

Do you u mean the screens dont reflect the configuration in Span and duplicate? this is intentional and artistic choice by me.

tickbox for antialiased scaling "Enable safe scaling" (keeping the jump in ×4pix increments or maybe even something more complex with performance options in mind (light/heavy))

I do not understand Enable safe scaling, the scaling algorithm is handled by the browser (CEF) or video player (Mpv.)

@Raf-UJ
Copy link
Author

Raf-UJ commented Jul 25, 2024

Personally I do not like adding sliders and too many configuration to the interface and instead try to keep things simple (...)

Sure thing, it was merely a suggestion of what I had in my head. I am sure you'd like to keep in line with the current interface following the scheme - which on the sidenote - I absolutely love, your sections are making this app so easy to navigate! Slider was the first thing that came to mind when I thought about it. It could be anything as long as allows user to fine tune the placement. It could be just a CenterPoint really:
image

Do you u mean the screens don't reflect the configuration in Span and duplicate?

This was more about the fact it did reflect the orientation on Screen but not on the Span, I actually like the overlap, it just made me think that "I am an edge case and this configuration was unaccounted for". That's all really

I do not understand Enable safe scaling,

I meant the freehand centerpoint adjusting would result in non-dividable pixels so blurry/artefacts etc. but as you pointed out it's handled by the engine so it's most likely a non-issue.

It was more of a "here is my thought it could be useful" scenario. I realised typing that original suggestion that having that little calculation in place that only allows stepped scaling by a factor of (for example) 1.02 would solve majority of the scaling artefacts. So "as granular as you can BUT with a limiter" - if that makes sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants