Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'old' Tag for Last Version #341

Open
surmann opened this issue Jun 11, 2019 · 4 comments
Open

Add 'old' Tag for Last Version #341

surmann opened this issue Jun 11, 2019 · 4 comments

Comments

@surmann
Copy link

surmann commented Jun 11, 2019

It would be nice to have a tag for the last R version.

I test my package against 'devel', 'latest', and '3.4'. Progression to R 3.6 we have to update all our yml files from tag '3.4' to '3.5'. Here it would help to have the new tag 'old', for instance.

@nuest
Copy link

nuest commented Aug 7, 2019

In line with CRAN, this tag could be oldrel, and one can probably add this to the post_push tagging mechanism.

@cboettig
Copy link
Member

cboettig commented Aug 7, 2019

Thanks, keep meaning to get back to this but haven't done it. agree we just need a post_push hook to do this. @nuest want to send a PR for this?

@surmann
Copy link
Author

surmann commented Dec 3, 2019

Is it easy to write a peace of code which rolls the oldrel version forward related to the current version of R?

@cboettig
Copy link
Member

cboettig commented Dec 3, 2019

@surmann Yes, I think we just need to add the relevant logic to the post_push hook to create and push the extra tag. See https://github.com/rocker-org/rocker-versioned/blob/master/r-ver/hooks/post_push and the Docker docs on hooks. -- PRs welcome. Ideally this could be done in a way that doesn't require the script to be updated manually on each new R release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants