Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r-ver has python3 installed ... should it? #507

Closed
mmuurr opened this issue Jul 14, 2022 · 7 comments · Fixed by #509
Closed

r-ver has python3 installed ... should it? #507

mmuurr opened this issue Jul 14, 2022 · 7 comments · Fixed by #509
Labels
documentation Improvements or additions to documentation

Comments

@mmuurr
Copy link

mmuurr commented Jul 14, 2022

Container image name

rocker/r-ver:4.0.3

Container image digest

rocker/r-ver@sha256:c058532fe0273a5cb37898966a85b7df21e228b68158d4bcffb59fe5ec7b7767

What operating system are you seeing the problem on?

macOS

System information

No response

Bug description

rocker/r-ver:4.0.3 seems to have python3 already installed, but when walking through the Dockerfiles and stack JSON files, it looks to me like that's unintended. I only discovered this when trying to install python3 myself on top of this image and found a version mismatch. More evidence suggesting this is unintended:

  1. ubuntu:focal (r-ver's base layer) does not have python3 installed.
  2. The repo's README says, "Adds cuda and Python to 'r-ver'" (suggesting Python) is not expected to be part of r-ver.

Perhaps this is intended?

How to reproduce this bug?

docker run -it --rm rocker/r-ver:4.0.3 python3 --version
@mmuurr mmuurr added the bug Something isn't working label Jul 14, 2022
@eitsupi
Copy link
Member

eitsupi commented Jul 15, 2022

I think this is a documentation issue.
rocker/r-ver seems to install python3 at the following location (devscripts).

apt-get install -y --no-install-recommends \
bash-completion \
ca-certificates \
devscripts \

https://packages.ubuntu.com/en/bionic/devscripts

But I don't understand why devscripts is here and what is really needed.

@eitsupi eitsupi added documentation Improvements or additions to documentation and removed bug Something isn't working labels Jul 20, 2022
@benz0li
Copy link
Contributor

benz0li commented Jul 20, 2022

@eitsupi Cross reference: rocker-org/rocker-versioned#166

@eitsupi
Copy link
Member

eitsupi commented Jul 20, 2022

@benz0li Thanks for sharing that. I am convinced.

@benz0li
Copy link
Contributor

benz0li commented Jul 20, 2022

Added here: 7e065a9

@eitsupi
Copy link
Member

eitsupi commented Jul 20, 2022

Tracking this discussion, I see that rocker/drd doesn't like the devscripts dependencies (like python3) and only extracts checkbashisms and includes it in the source code.

rocker-org/rocker-versioned#167 (comment)
https://github.com/rocker-org/drd/blob/06ab465832ab7c77335d16f9e934d03bdb0493c4/checkbashisms

I suppose we could do the same thing here.

@eddelbuettel
Copy link
Member

I had very much forgotten about that but yes -- I noticed that to run checkbashishm I didn't need all the other parts, and the script itself was both small and stable (as in: no or few changes in recent years) so I guess I just 'vendored' it.

@eitsupi
Copy link
Member

eitsupi commented Jul 21, 2022

I have created a new issue #510 about the installation of devscripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants