Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check on a list being used for MIDDLEWARE and INSTALLED_APPS #80

Open
bittner opened this issue Dec 7, 2020 · 0 comments
Open

Check on a list being used for MIDDLEWARE and INSTALLED_APPS #80

bittner opened this issue Dec 7, 2020 · 0 comments

Comments

@bittner
Copy link

bittner commented Dec 7, 2020

Would it make sense to check on a list being used for MIDDLEWARE and INSTALLED_APPS?

Motivation

Django originally used tuples for INSTALLED_APPS and MIDDLEWARE_CLASSES.

That's why, when projects are migrated to newer Django versions, those will remain to be tuples (even when renamed to MIDDLEWARE, for example). While this does not pose any direct problem for iterating over those values, it can be a problem when code tries to manipulate those objects. They should really be lists in modern Django code, consistently.

Real-world Examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant