Creating a static folder removes the default static files needed by the default template

[gerrod3]

I wanted to change the default favicon that is generated so I added a favicon.ico in my source directory. Noticed it didn't change anything so I looked at the generated source and saw it was pulling it from static/favicon.ico, so I created a static folder and put it there. Then upon push to github and my webhoster building my site I notice none of the static files were loading. Looking at the logs I noticed none of the files were there, just the favicon I added, even though they were present in my local build. I think these lines getting the static files need to account for grabbing the default static files if the default template is being used:

marmite/src/site.rs

Lines 691 to 707 in 0008518

	if static_source.is_dir() {
	let mut options = CopyOptions::new();
	options.overwrite = true; // Overwrite files if they already exist
	if let Err(e) = dircopy(&static_source, &**output_folder, &options) {
	error!("Failed to copy static directory: {}", e);
	process::exit(1);
	}
	info!(
	"Copied '{}' to '{}/'",
	&static_source.display(),
	&output_folder.display()
	);
	} else {
	generate_static(&output_folder.join(site_data.site.static_path.clone()));
	}

[rochacbruno]

The problem was here

marmite/src/site.rs

Line 669 in 8925fe0

("favicon.ico", String::new()),

It was copying favicon only to the root of the site, when it must copy to the static folder.

I already fixed as part of #174

My idea is that you can drop a favicon.ico on the source folder (or content folder) and it will be copied to the output/static, no need to create your own static dir.

[gerrod3]

What about adding extra static files while using the default template? Seems like you have to manually copy the generated files if you want to add custom files.

[rochacbruno]

The current logic is that if static/ does not exist on the source folder, it will be copied from the embedded files to the output dir.

If it exists, then avoid copying so it will not override if using a custom theme.

You can override CSS and JS using the custom_ files, if more change is needed on the theme, then you can start your own theme.

marmite source --start-theme

Then it will copy templates and static from embedded to your source folder, and you can fully customize.

---

How can we improve?

Can you give me an example of a static that you would override or add?

Maybe we add a config option like merge_static: true --merge-static true